Skip to content

OLS-1492 - Adapt tests to update config dynamically. #2615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OLS-1492 - Adapt tests to update config dynamically. #2615

wants to merge 1 commit into from

Conversation

sriroopar
Copy link
Contributor

Description

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 17, 2025
@sriroopar
Copy link
Contributor Author

/retest

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xrajesh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sriroopar
Copy link
Contributor Author

/retest

@sriroopar
Copy link
Contributor Author

/test 4.18-e2e-ols-cluster

5 similar comments
@sriroopar
Copy link
Contributor Author

/test 4.18-e2e-ols-cluster

@sriroopar
Copy link
Contributor Author

/test 4.18-e2e-ols-cluster

@xrajesh
Copy link
Contributor

xrajesh commented Sep 18, 2025

/test 4.18-e2e-ols-cluster

@xrajesh
Copy link
Contributor

xrajesh commented Sep 22, 2025

/test 4.18-e2e-ols-cluster

@sriroopar
Copy link
Contributor Author

/test 4.18-e2e-ols-cluster

@sriroopar sriroopar force-pushed the srameshb-wip branch 6 times, most recently from 73d277d to 4ffef9f Compare September 28, 2025 16:32
@sriroopar
Copy link
Contributor Author

/retest

@sriroopar sriroopar closed this Sep 28, 2025
@sriroopar sriroopar reopened this Sep 28, 2025
@sriroopar sriroopar force-pushed the srameshb-wip branch 2 times, most recently from 4ffef9f to f78aea1 Compare September 29, 2025 11:25
@sriroopar
Copy link
Contributor Author

/retest-required

@sriroopar
Copy link
Contributor Author

/retest

1 similar comment
@sriroopar
Copy link
Contributor Author

/retest

@sriroopar
Copy link
Contributor Author

/test e2e-ols-cluster

@sriroopar
Copy link
Contributor Author

/retest

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 12, 2025
JoaoFula
JoaoFula reviewed Oct 14, 2025
View reviewed changes
@JoaoFula
Copy link
Contributor

one repair regarding the disconnected tests, otherwise seems good

@JoaoFula
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2025
@sriroopar
Copy link
Contributor Author

/retest

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 14, 2025

New changes are detected. LGTM label has been removed.

@sriroopar sriroopar requested a review from JoaoFula October 14, 2025 14:10
@sriroopar
Functionality to adapt to OLSConfig for multi-provider support.
f5bfc70 
 #Restructuring and adding new logs.

 #Linter fix.

 #trial fix for roopa pr
@sriroopar
Copy link
Contributor Author

/test e2e-ols-cluster

@sriroopar
Copy link
Contributor Author

/retest-required

@sriroopar
Copy link
Contributor Author

/retest

4 similar comments
@sriroopar
Copy link
Contributor Author

/retest

@sriroopar
Copy link
Contributor Author

/retest

@sriroopar
Copy link
Contributor Author

/retest

@sriroopar
Copy link
Contributor Author

/retest

@sriroopar
Copy link
Contributor Author

/retest

1 similar comment
@sriroopar
Copy link
Contributor Author

/retest

@sriroopar
Copy link
Contributor Author

/retest

@sriroopar
Copy link
Contributor Author

/test e2e-ols-cluster

@sriroopar sriroopar closed this Oct 16, 2025
@sriroopar sriroopar reopened this Oct 16, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 16, 2025 •
edited
Loading

@sriroopar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.18-e2e-ols-cluster ddecbf0 link true /test 4.18-e2e-ols-cluster

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sriroopar
Copy link
Contributor Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshuawilson joshuawilson Awaiting requested review from joshuawilson

@xrajesh xrajesh Awaiting requested review from xrajesh

@JoaoFula JoaoFula Awaiting requested review from JoaoFula

Assignees

@JoaoFula JoaoFula

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sriroopar @xrajesh @JoaoFula